danny0405 commented on code in PR #10227:
URL: https://github.com/apache/hudi/pull/10227#discussion_r1412715512
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -349,6 +350,8 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable catalogTable, boo
final String partitions = String.join(",",
resolvedTable.getPartitionKeys());
conf.setString(FlinkOptions.PARTITION_PATH_FIELD, partitions);
options.put(TableOptionProperties.PARTITION_COLUMNS, partitions);
+ } else {
+ conf.setString(FlinkOptions.KEYGEN_CLASS_NAME.key(),
NonpartitionedAvroKeyGenerator.class.getName());
Review Comment:
Thanks for the fix, can you add a basic validation for the keygen class in
`TestHoodieCatalog` and `TestHoodieHiveCatalog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
