jonvex commented on code in PR #10225: URL: https://github.com/apache/hudi/pull/10225#discussion_r1422912797
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala: ########## @@ -65,6 +66,8 @@ class HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState, requiredFilters: Seq[Filter] ) extends ParquetFileFormat with SparkAdapterSupport with HoodieFormatTrait { + override def getRequiredFilters: Seq[Filter] = requiredFilters Review Comment: No. The override is implementing the method from the trait. I think "override" might not be necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org