linliu-code commented on PR #10255: URL: https://github.com/apache/hudi/pull/10255#issuecomment-1858435541
Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org