nsivabalan commented on code in PR #10342:
URL: https://github.com/apache/hudi/pull/10342#discussion_r1429201396
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -998,9 +996,9 @@ public void runMetaSync() {
* this constraint.
*/
private void setupWriteClient(Option<JavaRDD<HoodieRecord>> recordsOpt)
throws IOException {
- if ((null != schemaProvider)) {
+ if (null != schemaProvider) {
Schema sourceSchema = schemaProvider.getSourceSchema();
- Schema targetSchema = schemaProvider.getTargetSchema();
+ Schema targetSchema =
getSchemaForWriteConfig(schemaProvider.getTargetSchema());
Review Comment:
we call reInitWriteClient twice in this class. If we wer fixing the target
schema here to go through getSchemaForWriteConfig, should we fix the other
caller as well.
Also, looks like we are calling getSchemaForWriteConfig within
reInitWriteClient(), should we remove that call if callers already take care of
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
