danny0405 commented on code in PR #10388: URL: https://github.com/apache/hudi/pull/10388#discussion_r1435444510
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java: ########## @@ -96,6 +96,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) { // Append mode if (OptionsResolver.isAppendMode(conf)) { + // close compaction for append mode + conf.set(FlinkOptions.COMPACTION_SCHEDULE_ENABLED, false); Review Comment: For append mode, we mean COW + INSERT, that means `needsScheduleCompaction` returns false, and there will never schdule any compaction plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org