empcl commented on code in PR #10413:
URL: https://github.com/apache/hudi/pull/10413#discussion_r1437415765
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RepairOverwriteHoodiePropsProcedure.scala:
##########
@@ -57,7 +67,7 @@ class RepairOverwriteHoodiePropsProcedure extends
BaseProcedure with ProcedureBu
val metaClient =
HoodieTableMetaClient.builder.setConf(jsc.hadoopConfiguration()).setBasePath(tablePath).build
var newProps = new Properties
- newProps.load(new FileInputStream(overwriteFilePath))
+ loadNewProps(overwriteFilePath, newProps)
Review Comment:
hi, introduction in Fileinputstream code: `What files are available depends
on the host environment.`.
When using `repair_overwrite_hoodie_props`, it is necessary to specify the
location of the properties. Obviously, using FileInputStream will not be able
to read data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
