vinothchandar commented on a change in pull request #1149:
URL: https://github.com/apache/hudi/pull/1149#discussion_r463422364



##########
File path: 
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
##########
@@ -161,6 +161,17 @@ public static void writePartitionMetadata(FileSystem fs, 
String[] partitionPaths
     }
   }
 
+  public static List<HoodieRecord> newHoodieRecords(int n, String time) throws 
Exception {

Review comment:
       but i actually find it surprising we needed to add one. This class as-is 
is a medley of different individual methods. I would really like to avoid 
overloading this more. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to