bvaradar commented on a change in pull request #1888:
URL: https://github.com/apache/hudi/pull/1888#discussion_r463504707
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/AvroConversionHelper.scala
##########
@@ -136,7 +136,7 @@ object AvroConversionHelper {
case (struct: StructType, RECORD) =>
val length = struct.fields.length
val converters = new Array[AnyRef => AnyRef](length)
- val avroFieldIndexes = new Array[Int](length)
+ val avroFieldNames = new Array[String](length)
Review comment:
Question : Does this work for nested schemas where same name is used in
different hierarchy ? For example : "order.rec.rec" (I am just making this up)
but wanted to make sure if there are any chances of ambiguity in field
resolution that can arise ? Can you add some test-cases to verify this would
work fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
