paul8263 commented on code in PR #10497:
URL: https://github.com/apache/hudi/pull/10497#discussion_r1454372097
##########
hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/vector/reader/ParquetColumnarRowSplitReader.java:
##########
@@ -218,11 +218,17 @@ private WritableColumnVector[] createWritableVectors() {
List<Type> types = requestedSchema.getFields();
List<ColumnDescriptor> descriptors = requestedSchema.getColumns();
for (int i = 0; i < requestedTypes.length; i++) {
- columns[i] = createWritableColumnVector(
- batchSize,
- requestedTypes[i],
- types.get(i),
- descriptors);
+ String fieldName = requestedSchema.getFieldName(i);
Review Comment:
Hi @danny0405 ,
Correct. It should be moved to the catch block as it would be only needed if
there was an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
