nsivabalan commented on code in PR #10342: URL: https://github.com/apache/hudi/pull/10342#discussion_r1462179473
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/InputBatch.java: ########## @@ -55,7 +55,7 @@ public SchemaProvider getSchemaProvider() { if (batch.isPresent() && schemaProvider == null) { throw new HoodieException("Please provide a valid schema provider class!"); } - return Option.ofNullable(schemaProvider).orElse(new NullSchemaProvider()); Review Comment: minor. do you think we can statically define once and use it rather than creating new objects everytime ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org