vinothchandar commented on code in PR #10512: URL: https://github.com/apache/hudi/pull/10512#discussion_r1480408115
########## Dockerfile: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Use a home made image as the base, which includes: Review Comment: does this need to be at the root of the project? is it possible to have it under a `azure-ci` folder, so everyone knows what this is about. Else, please clearly document how/who uses this Dockerfile. ########## azure-pipelines-20230430.yml: ########## @@ -201,35 +201,30 @@ stages: displayName: UT FT other modules timeoutInMinutes: '240' steps: - - task: Maven@4 - displayName: maven install + - task: Docker@2 + displayName: "build docker image" Review Comment: the image is not built each CI run, right? ########## azure-pipelines-20230430.yml: ########## @@ -98,7 +98,7 @@ parameters: variables: BUILD_PROFILES: '-Dscala-2.12 -Dspark3.2 -Dflink1.18' PLUGIN_OPTS: '-Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn' - MVN_OPTS_INSTALL: '-Phudi-platform-service -DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS) -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=5' Review Comment: whats the impact of this change? are we excluding this module ########## hudi-platform-service/hudi-metaserver/hudi-metaserver-server/pom.xml: ########## @@ -92,6 +92,34 @@ </plugins> </build> </profile> + <profile> + <id>thrift-gen-source-with-script</id> Review Comment: do we need to separate them? is it easy to get GH CI to use the plugin as well? if so, lets do it in this same PR ########## azure-pipelines-20230430.yml: ########## @@ -201,35 +201,30 @@ stages: displayName: UT FT other modules timeoutInMinutes: '240' steps: - - task: Maven@4 - displayName: maven install + - task: Docker@2 + displayName: "build docker image" inputs: - mavenPomFile: 'pom.xml' - goals: 'clean install' - options: $(MVN_OPTS_INSTALL) - publishJUnitResults: true - testResultsFiles: '**/surefire-reports/TEST-*.xml' - jdkVersionOption: '1.8' - - task: Maven@4 - displayName: UT other modules + containerRegistry: 'onehouse-docker-hub' Review Comment: lets keep onehouse out of this PR. Can we just use the apachehudi docker hub ########## hudi-platform-service/hudi-metaserver/hudi-metaserver-server/pom.xml: ########## @@ -92,6 +92,34 @@ </plugins> </build> </profile> + <profile> + <id>thrift-gen-source-with-script</id> Review Comment: IIUC the script must be installing thrift already. We can just replace the build steps with a mvn command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
