nsivabalan commented on code in PR #10635:
URL: https://github.com/apache/hudi/pull/10635#discussion_r1484934049
##########
hudi-common/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java:
##########
@@ -66,28 +64,29 @@ public static Option<MetricsReporter>
createReporter(HoodieWriteConfig config, M
switch (type) {
case GRAPHITE:
- reporter = new MetricsGraphiteReporter(config, registry);
+ reporter = new MetricsGraphiteReporter(metricsConfig, registry);
break;
case INMEMORY:
reporter = new InMemoryMetricsReporter();
break;
case JMX:
- reporter = new JmxMetricsReporter(config, registry);
+ reporter = new JmxMetricsReporter(metricsConfig, registry);
break;
case DATADOG:
- reporter = new DatadogMetricsReporter(config, registry);
+ reporter = new DatadogMetricsReporter(metricsConfig, registry);
break;
case PROMETHEUS_PUSHGATEWAY:
- reporter = new PushGatewayMetricsReporter(config, registry);
+ reporter = new PushGatewayMetricsReporter(metricsConfig, registry);
break;
case PROMETHEUS:
- reporter = new PrometheusReporter(config, registry);
+ reporter = new PrometheusReporter(metricsConfig, registry);
break;
case CONSOLE:
reporter = new ConsoleMetricsReporter(registry);
break;
case CLOUDWATCH:
- reporter = new CloudWatchMetricsReporter(config, registry);
+ reporter = (MetricsReporter)
ReflectionUtils.loadClass("org.apache.hudi.metrics.cloudwatch.CloudWatchMetricsReporter",
Review Comment:
why we could not access CloudWatchMetricsReporter?
we are changing the arg in the constructor from write config to
metricsconfig right.
should we not just use the new constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
