yihua commented on code in PR #10687: URL: https://github.com/apache/hudi/pull/10687#discussion_r1495114452
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamProfile.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.utilities.streamer; + +/** + * A profile containing details about how the next input batch in StreamSync should be consumed and written. + * For eg: KafkaStreamProfile contains number of events to consume in this sync round. + * S3StreamProfile contains the list of files to consume in this sync round. + * HudiIncrementalStreamProfile contains the beginInstant and endInstant commit times to consume in this sync round etc. + * + * @param <T> The type for source context, varies based on sourceType as described above. + */ +public interface StreamProfile<T> { Review Comment: Add annotation for public interface: `@PublicAPIClass(maturity = ApiMaturityLevel.EVOLVING)` ########## hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamProfile.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.utilities.streamer; + +/** + * A profile containing details about how the next input batch in StreamSync should be consumed and written. + * For eg: KafkaStreamProfile contains number of events to consume in this sync round. + * S3StreamProfile contains the list of files to consume in this sync round. + * HudiIncrementalStreamProfile contains the beginInstant and endInstant commit times to consume in this sync round etc. + * + * @param <T> The type for source context, varies based on sourceType as described above. + */ +public interface StreamProfile<T> { + + /** + * @return The maxBytes that will be consumed from the source in this sync round. + */ + long getMaxSourceBytes(); Review Comment: same for methods: `@PublicAPIMethod(maturity = ApiMaturityLevel. EVOLVING)` ########## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java: ########## @@ -55,11 +57,17 @@ protected Source(TypedProperties props, JavaSparkContext sparkContext, SparkSess protected Source(TypedProperties props, JavaSparkContext sparkContext, SparkSession sparkSession, SchemaProvider schemaProvider, SourceType sourceType) { + this(props, sparkContext, sparkSession, schemaProvider, sourceType, Option.empty()); + } + + protected Source(TypedProperties props, JavaSparkContext sparkContext, SparkSession sparkSession, + SchemaProvider schemaProvider, SourceType sourceType, Option<StreamProfileSupplier> streamProfilerSupplier) { Review Comment: Maybe it's better to have an interface class `StreamContext` wrapping all `SchemaProvider schemaProvider, SourceType sourceType, Option<StreamProfileSupplier> streamProfilerSupplier` so it's flexible to extend the context without changing the constructor once more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
