lw309637554 commented on a change in pull request #1810: URL: https://github.com/apache/hudi/pull/1810#discussion_r465449363
########## File path: hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/AbstractSyncHoodieClient.java ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.sync.common; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.TableSchemaResolver; +import org.apache.hudi.common.table.timeline.HoodieTimeline; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.exception.HoodieIOException; + +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.parquet.schema.MessageType; + +import java.io.IOException; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public abstract class AbstractSyncHoodieClient { + private static final Logger LOG = LogManager.getLogger(AbstractSyncHoodieClient.class); + protected final HoodieTableMetaClient metaClient; + protected HoodieTimeline activeTimeline; + protected final HoodieTableType tableType; + protected final FileSystem fs; + private String basePath; + private boolean assumeDatePartitioning; + + public AbstractSyncHoodieClient(String basePath, boolean assumeDatePartitioning, FileSystem fs) { + this.metaClient = new HoodieTableMetaClient(fs.getConf(), basePath, true); + this.tableType = metaClient.getTableType(); + this.basePath = basePath; + this.assumeDatePartitioning = assumeDatePartitioning; + this.fs = fs; + this.activeTimeline = metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(); + } + + public abstract void createTable(String tableName, MessageType storageSchema, + String inputFormatClass, String outputFormatClass, String serdeClass); + + public abstract boolean doesTableExist(String tableName); + + public abstract Option<String> getLastCommitTimeSynced(String tableName); + + public abstract void updateLastCommitTimeSynced(String tableName); + + public abstract void addPartitionsToTable(String tableName, List<String> partitionsToAdd); + + public abstract void updatePartitionsToTable(String tableName, List<String> changedPartitions); + + public abstract Map<String, String> getTableSchema(String tableName); + + public HoodieTimeline getActiveTimeline() { + return activeTimeline; + } + + public HoodieTableType getTableType() { + return tableType; + } + + public String getBasePath() { + return metaClient.getBasePath(); + } + + public FileSystem getFs() { + return fs; + } + + public void closeQuietly(ResultSet resultSet, Statement stmt) { + try { + if (stmt != null) { + stmt.close(); + } + } catch (SQLException e) { + LOG.error("Could not close the statement opened ", e); Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
