wombatu-kun commented on code in PR #10866:
URL: https://github.com/apache/hudi/pull/10866#discussion_r1529606592
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJdbcSource.java:
##########
@@ -73,12 +73,12 @@ public static void beforeAll() throws Exception {
@BeforeEach
public void setup() throws Exception {
super.setup();
- PROPS.setProperty("hoodie.deltastreamer.jdbc.url", "jdbc:h2:mem:test_mem");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.driver.class",
"org.h2.Driver");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.user", "test");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.password", "jdbc");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.table.name", "triprec");
- connection = DriverManager.getConnection("jdbc:h2:mem:test_mem", "test",
"jdbc");
+ PROPS.setProperty("hoodie.streamer.jdbc.url", "jdbc:h2:mem:test_mem");
+ PROPS.setProperty("hoodie.streamer.jdbc.driver.class", "org.h2.Driver");
+ PROPS.setProperty("hoodie.streamer.jdbc.user", "sa");
+ PROPS.setProperty("hoodie.streamer.jdbc.password", "");
+ PROPS.setProperty("hoodie.streamer.jdbc.table.name", "triprec");
+ connection = DriverManager.getConnection("jdbc:h2:mem:test_mem", "sa", "");
Review Comment:
reverted, will do it in separate PR.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJdbcSource.java:
##########
@@ -438,7 +438,7 @@ public void testSourceWithStorageLevel() {
private void writeSecretToFs() throws IOException {
FileSystem fs = FileSystem.get(new Configuration());
FSDataOutputStream outputStream = fs.create(new
Path("file:///tmp/hudi/config/secret"));
- outputStream.writeBytes("jdbc");
+ outputStream.writeBytes("");
Review Comment:
reverted, will do it in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
