sampan-s-nayak commented on code in PR #10890:
URL: https://github.com/apache/hudi/pull/10890#discussion_r1535049167


##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestKafkaOffsetGen.java:
##########
@@ -119,6 +122,28 @@ public void testGetNextOffsetRangesFromCheckpoint() {
     assertEquals(750, nextOffsetRanges[0].untilOffset());
   }
 
+  @ParameterizedTest
+  @ValueSource(strings = {"latest","earliest"})
+  public void testGetNextOffsetRangesWhenUsingResetCheckpoint(String 
autoOffsetResetConfig) {
+    String resetCheckpoint = String.format("%s:reset-%s",testTopicName, 
Instant.now().toEpochMilli());

Review Comment:
   waiting for commits seems to be hard to implement so skipping this based on 
an offline discussion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to