bhat-vinay commented on code in PR #10876:
URL: https://github.com/apache/hudi/pull/10876#discussion_r1535694790


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -480,6 +480,20 @@ public class HoodieWriteConfig extends HoodieConfig {
       .markAdvanced()
       .withDocumentation(BulkInsertSortMode.class);
 
+  public static final ConfigProperty<Boolean> INSERT_SORT = ConfigProperty

Review Comment:
   Done. IIUC, you are asking to use `BulkInsertSortMode::NONE` and 
`BulkInsertSortMode::GLOBAL_SORT` (instead of a boolean). FYI,  there are no 
sort modes for `insert`. There is only global sort (i.e sort the entire input 
batch). Hence the valid values are NONE or GLOBAL_SORT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to