parisni commented on code in PR #10897:
URL: https://github.com/apache/hudi/pull/10897#discussion_r1536698280
##########
hudi-aws/src/test/java/org/apache/hudi/aws/sync/ITTestGluePartitionPushdown.java:
##########
@@ -131,8 +151,40 @@ public void testEmptyPartitionShouldReturnEmpty() {
@Test
public void testPresentPartitionShouldReturnIt() throws ExecutionException,
InterruptedException {
- createPartitions("1", "b'ar");
+ List<String> partitions = createPartitions(1, 2, true);
Assertions.assertEquals(1, glueSync.getPartitionsFromList(TABLE_NAME,
- Arrays.asList("1/b'ar", "2/foo", "1/b''ar")).size());
+ Arrays.asList(partitions.get(0), "2/foo", "1/b''ar")).size());
Review Comment:
for clarity, maybe :
```suggestion
Arrays.asList(partitions.get(0), "1/non-existing",
"2/other-non''-existing")).size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
