danny0405 commented on code in PR #10965: URL: https://github.com/apache/hudi/pull/10965#discussion_r1556682595
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ########## @@ -1135,8 +1137,34 @@ protected void completeLogCompaction(HoodieCommitMetadata metadata, HoodieTable */ protected HoodieWriteMetadata<O> compact(String compactionInstantTime, boolean shouldComplete) { HoodieTable table = createTable(config, context.getHadoopConf().get()); + Option<HoodieInstant> instantToCompactOption = Option.fromJavaOptional(table.getActiveTimeline() + .filterCompletedAndCompactionInstants() + .getInstants() + .stream() + .filter(instant -> HoodieActiveTimeline.EQUALS.test(instant.getTimestamp(), compactionInstantTime)) Review Comment: we should only care about pending instant right? If the compaction already completed, just skip this run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org