beyond1920 commented on code in PR #10980: URL: https://github.com/apache/hudi/pull/10980#discussion_r1556818304
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ########## @@ -147,6 +149,13 @@ public HoodieMergeHandle(HoodieWriteConfig config, String instantTime, HoodieTab this.preserveMetadata = true; init(fileId, this.partitionPath, dataFileToBeMerged); validateAndSetAndKeyGenProps(keyGeneratorOpt, config.populateMetaFields()); + // The compactor avoids heavy rewriting when copy the old record from old base file into new base file + if (config.populateMetaFields()) { + LOG.info("Using update instead rewriting during compaction"); Review Comment: > Set the log as debug level Using info level here does not cost much, right? > "instead" -> "instead of". Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org