nsivabalan commented on code in PR #10635:
URL: https://github.com/apache/hudi/pull/10635#discussion_r1556836048
##########
hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java:
##########
@@ -176,4 +190,16 @@ public static boolean isInitialized(String basePath) {
}
return false;
}
+
+ /**
+ * Use the same base path as the hudi table so that Metrics instance is
shared.
+ */
+ private static String getBasePath(HoodieMetricsConfig metricsConfig) {
+ String basePath = metricsConfig.getBasePath();
+ if (basePath.endsWith(HoodieTableMetaClient.METADATA_TABLE_FOLDER_PATH)) {
Review Comment:
my bad.
```
public static final String METADATA_TABLE_FOLDER_PATH = METAFOLDER_NAME +
Path.SEPARATOR + "metadata";
```
looks like we already account for what I asked for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
