jonvex commented on code in PR #10998: URL: https://github.com/apache/hudi/pull/10998#discussion_r1562940754
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ########## @@ -964,6 +964,11 @@ object DataSourceOptionsHelper { def translateConfigurations(optParams: Map[String, String]): Map[String, String] = { val translatedOpt = scala.collection.mutable.Map[String, String]() ++= optParams + if (!translatedOpt.contains(HoodieTableConfig.NAME.key()) && Review Comment: I don't think this makes things worse than they already are with spark configs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org