Re: [PR] [MINOR] Optimization function MergeOnReadTableState#getRequiredPositions [hudi]

[via GitHub]

zhuanshenbsj1 commented on code in PR #11031:
URL: https://github.com/apache/hudi/pull/11031#discussion_r1568167071


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadTableState.java:
##########
@@ -83,11 +96,20 @@ public int getOperationPos() {
   }
 
   public int[] getRequiredPositions() {
-    final List<String> fieldNames = rowType.getFieldNames();

Review Comment:
   The method getRequiredPositions is called by objects CdcInputFormat and 
MergeOnReadInputFormat，neither of these two objects stores table names.
   
![image](https://github.com/apache/hudi/assets/34104400/4981da57-81e7-4c3c-92a0-a10f48c4e0bb)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org