yihua commented on code in PR #10591: URL: https://github.com/apache/hudi/pull/10591#discussion_r1571109412
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java: ########## @@ -281,36 +281,30 @@ public Writer build() throws IOException { rolloverLogWriteToken = rolloverLogWriteToken + suffix; } - Path logPath = new Path(parentPath, + HoodieLocation logPath = new HoodieLocation(parentPath, FSUtils.makeLogFileName(logFileId, fileExtension, instantTime, logVersion, logWriteToken)); LOG.info("HoodieLogFile on path " + logPath); HoodieLogFile logFile = new HoodieLogFile(logPath, fileLen); - if (bufferSize == null) { Review Comment: This is moved to the writer constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org