yihua commented on code in PR #11148:
URL: https://github.com/apache/hudi/pull/11148#discussion_r1590072865
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/SimpleConcurrentFileWritesConflictResolutionStrategy.java:
##########
@@ -68,6 +69,7 @@ public Stream<HoodieInstant>
getCandidateInstants(HoodieTableMetaClient metaClie
.getTimelineOfActions(CollectionUtils.createSet(REPLACE_COMMIT_ACTION,
COMPACTION_ACTION))
.findInstantsAfter(currentInstant.getTimestamp())
.filterInflightsAndRequested()
+ .filter(i -> (!i.getAction().equals(COMPACTION_ACTION)) ||
i.getState().equals(REQUESTED))
.getInstantsAsStream();
Review Comment:
@linliu-code We still need to check the compaction for conflict correct? So
instead of filtering out `compaction.inflight`, we should convert
`instant.compaction.inflight` to `instant.compaction.request` for checking?
Can you write a test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
