jonvex commented on code in PR #11163:
URL: https://github.com/apache/hudi/pull/11163#discussion_r1595533050
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkFileWriterFactory.java:
##########
@@ -82,7 +82,7 @@ protected HoodieFileWriter newParquetFileWriter(
config.getLong(HoodieStorageConfig.PARQUET_MAX_FILE_SIZE),
writeSupport.getHadoopConf(),
config.getDouble(HoodieStorageConfig.PARQUET_COMPRESSION_RATIO_FRACTION),
config.getBooleanOrDefault(HoodieStorageConfig.PARQUET_DICTIONARY_ENABLED));
- parquetConfig.getHadoopConf().addResource(writeSupport.getHadoopConf());
+ writeSupport.getHadoopConf().addResource(writeSupport.getHadoopConf());
Review Comment:
reverted this. But still not sure if it makes sense.
writeSupport.getHadoopConf() is in the constructor of the parquet config. So it
is still adding itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
