jonvex commented on code in PR #11190: URL: https://github.com/apache/hudi/pull/11190#discussion_r1597018880
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java: ########## @@ -121,7 +122,7 @@ protected byte[] serializeRecords(List<HoodieRecord> records) throws IOException HFileContext context = new HFileContextBuilder() .withBlockSize(DEFAULT_BLOCK_SIZE) .withCompression(compressionAlgorithm.get()) - .withCellComparator(new HoodieHBaseKVComparator()) + .withCellComparator(ReflectionUtils.loadClass(KV_COMPARATOR_CLASS_NAME)) Review Comment: We're going to get rid of this because this HFileContext is dependent on hadoop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org