yihua commented on code in PR #11189:
URL: https://github.com/apache/hudi/pull/11189#discussion_r1597244371
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RepairsCommand.java:
##########
@@ -123,7 +121,7 @@ public String addPartitionMeta(
client.getActiveTimeline().getCommitTimeline().lastInstant().get().getTimestamp();
List<String> partitionPaths =
FSUtils.getAllPartitionFoldersThreeLevelsDown(HoodieCLI.storage,
client.getBasePath());
- StoragePath basePath = new StoragePath(client.getBasePath());
+ StoragePath basePath = client.getBasePathV2();
Review Comment:
Could you create a JIRA to remove `getBasePathV2()` and return `StoragePath`
from `getBasePath()` as a follow-up?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -294,11 +294,20 @@ public HoodieTableType getTableType() {
/**
* @return Meta path
+ * @deprecated please use {@link #getMetaPathV2()}
*/
+ @Deprecated
Review Comment:
Can we directly change this method to return `StoragePath` and `metaPath`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
