jonvex commented on code in PR #10922:
URL: https://github.com/apache/hudi/pull/10922#discussion_r1599181476
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -654,22 +640,6 @@ private HoodieLogBlock.HoodieLogBlockType
pickLogDataBlockFormat() {
}
}
- private static Map<HeaderMetadataType, String>
getUpdatedHeader(Map<HeaderMetadataType, String> header, int
blockSequenceNumber, long attemptNumber,
-
HoodieWriteConfig config, boolean addBlockIdentifier) {
- Map<HeaderMetadataType, String> updatedHeader = new HashMap<>(header);
- if (addBlockIdentifier &&
!HoodieTableMetadata.isMetadataTable(config.getBasePath())) { // add block
sequence numbers only for data table.
- updatedHeader.put(HeaderMetadataType.BLOCK_IDENTIFIER, attemptNumber +
"," + blockSequenceNumber);
- }
- if (config.shouldWritePartialUpdates()) {
Review Comment:
@nsivabalan we need to keep this part with the partial update flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
