danny0405 commented on code in PR #11267:
URL: https://github.com/apache/hudi/pull/11267#discussion_r1610822698


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/FileSystemBasedLockProvider.java:
##########
@@ -96,6 +96,7 @@ public void close() {
     synchronized (LOCK_FILE_NAME) {
       try {
         fs.delete(this.lockFile, true);
+        fs.close();

Review Comment:
   Usually there is no need to close the filesystem because there are some 
reuse strategy on the HADOOP CLASSPATH, if we close the fs instance, it could 
induce exception for other invokers that are using this fs instance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to