jonvex commented on code in PR #10957:
URL: https://github.com/apache/hudi/pull/10957#discussion_r1630234605
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/common/table/read/TestSpark35RecordPositionMetadataColumn.scala:
##########
@@ -69,81 +64,54 @@ class TestSpark35RecordPositionMetadataColumn extends
SparkClientFunctionalTestH
@Test
def testRecordPositionColumn(): Unit = {
- val _spark = spark
- // Prepare the schema
- val dataSchema = new StructType(
- Array(
- StructField("userid", IntegerType, nullable = false),
- StructField("country", StringType, nullable = false),
- StructField("ts", StringType, nullable = false)
+ //feature is only supported in spark 3.5+
+ if (HoodieSparkUtils.gteqSpark3_5) {
+ val _spark = spark
+ // Prepare the schema
+ val dataSchema = new StructType(
+ Array(
+ StructField("userid", IntegerType, nullable = false),
+ StructField("country", StringType, nullable = false),
+ StructField("ts", StringType, nullable = false)
+ )
)
- )
- val requiredSchema = HoodieFileGroupReaderBasedParquetFileFormat
- .getAppliedRequiredSchema(
- dataSchema,
- shouldUseRecordPosition = true,
Review Comment:
ok, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
