jonvex commented on code in PR #10422: URL: https://github.com/apache/hudi/pull/10422#discussion_r1631634950
########## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableCompaction.java: ########## @@ -146,43 +147,50 @@ public void testWriteDuringCompaction(String payloadClass) throws IOException { @ParameterizedTest @MethodSource("writeLogTest") public void testWriteLogDuringCompaction(boolean enableMetadataTable, boolean enableTimelineServer) throws IOException { - Properties props = getPropertiesForKeyGen(true); - HoodieWriteConfig config = HoodieWriteConfig.newBuilder() - .forTable("test-trip-table") - .withPath(basePath()) - .withSchema(TRIP_EXAMPLE_SCHEMA) - .withParallelism(2, 2) - .withAutoCommit(true) - .withEmbeddedTimelineServerEnabled(enableTimelineServer) - .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(enableMetadataTable).build()) - .withCompactionConfig(HoodieCompactionConfig.newBuilder() - .withMaxNumDeltaCommitsBeforeCompaction(1).build()) - .withLayoutConfig(HoodieLayoutConfig.newBuilder() - .withLayoutType(HoodieStorageLayout.LayoutType.BUCKET.name()) - .withLayoutPartitioner(SparkBucketIndexPartitioner.class.getName()).build()) - .withIndexConfig(HoodieIndexConfig.newBuilder().fromProperties(props).withIndexType(HoodieIndex.IndexType.BUCKET).withBucketNum("1").build()) - .build(); - props.putAll(config.getProps()); - - metaClient = getHoodieMetaClient(HoodieTableType.MERGE_ON_READ, props); - client = getHoodieWriteClient(config); - - final List<HoodieRecord> records = dataGen.generateInserts("001", 100); - JavaRDD<HoodieRecord> writeRecords = jsc().parallelize(records, 2); + try { + //disable for this test because it seems like we process mor in a different order? Review Comment: https://issues.apache.org/jira/browse/HUDI-7610 Delete behavior is inconsistent and imo undefined. This is one of the advantages of unifying all the readers with FGReader is that we can remove the inconsistency between engines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org