yihua commented on code in PR #9894:
URL: https://github.com/apache/hudi/pull/9894#discussion_r1632119003


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -242,6 +249,11 @@ public HoodieFileGroupReaderIterator<T> 
getClosableIterator() {
     return new HoodieFileGroupReaderIterator<>(this);
   }
 
+  public static RecordMergeMode getRecordMergeMode(Properties props) {
+    String mergeMode = getStringWithAltKeys(props, 
HoodieCommonConfig.RECORD_MERGE_MODE, true).toUpperCase();

Review Comment:
   Right now, since there is only placeholder upgrade and downgrade methods 
from between table version 6 and 8, I added the inference of record merge mode 
inside `HoodieTableMetaClient$PropertyBuilder#build`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to