parisni commented on code in PR #9071:
URL: https://github.com/apache/hudi/pull/9071#discussion_r1685041260
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -330,7 +312,6 @@ && getTable(awsGlue, databaseName,
tableName).getPartitionKeys().equals(partitio
@Override
public void updateTableSchema(String tableName, MessageType newSchema) {
- // ToDo Cascade is set in Hive meta sync, but need to investigate how to
configure it for Glue meta
boolean cascade =
config.getSplitStrings(META_SYNC_PARTITION_FIELDS).size() > 0;
Review Comment:
Cascade is necessary when:
`schemaDifference.getUpdateColumnTypes()` is not empty (eg: field added in
between, or promotion type)
It is not necessary in other cases (`schemaDifference.getAddColumnTypes()`
or `.getDeleteColumns()`)
Then I think we should change the `updateTableSchema` signature to pass
`SchemaDifference` and let the metastore implementation decide to cascade or
not based on differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
