yihua commented on code in PR #11373: URL: https://github.com/apache/hudi/pull/11373#discussion_r1685278044
########## hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestProtoConversionUtil.java: ########## @@ -206,7 +233,7 @@ private Pair<Sample, GenericRecord> createInputOutputSampleWithRandomValues(Sche long primitiveFixedSignedLong = RANDOM.nextLong(); boolean primitiveBoolean = RANDOM.nextBoolean(); String primitiveString = randomString(10); - byte[] primitiveBytes = getUTF8Bytes(randomString(10)); + byte[] primitiveBytes = randomString(10).getBytes(); Review Comment: Similar here and below on the unintended changes. In OSS, we have explicitly enforced UTF-8, although `.getBytes()` implicitly uses `UTF-8` on UNIX-like systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org