stream2000 commented on code in PR #8374:
URL: https://github.com/apache/hudi/pull/8374#discussion_r1689056076
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -194,8 +194,11 @@ public void setOperatorEventGateway(OperatorEventGateway
operatorEventGateway) {
private void restoreWriteMetadata() throws Exception {
boolean eventSent = false;
+ HoodieTimeline pendingTimeline =
this.metaClient.getActiveTimeline().filterPendingExcludingCompaction();
for (WriteMetadataEvent event : this.writeMetadataState.get()) {
- if (Objects.equals(this.currentInstant, event.getInstantTime())) {
+ // Must filter out the completed instants in case it is a partial
failover,
Review Comment:
If I understand correctly, if the instant to recommit is rolled back by
another process (for example, because its heartbeat expired), it won't be
recommitted and the data within that instant will be lost, is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
