bvaradar commented on a change in pull request #1964: URL: https://github.com/apache/hudi/pull/1964#discussion_r475931147
########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.timeline; + +import org.apache.hudi.avro.model.HoodieCleanMetadata; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.exception.HoodieIOException; + +import java.io.IOException; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * TimelineUtils provides a common way to query incremental meta-data changes for a hoodie table. + * + * This is useful in multiple places including: + * 1) HiveSync - this can be used to query partitions that changed since previous sync. + * 2) Incremental reads - InputFormats can use this API to queryxw Review comment: typo : queryxw -> query ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.timeline; + +import org.apache.hudi.avro.model.HoodieCleanMetadata; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.exception.HoodieIOException; + +import java.io.IOException; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * TimelineUtils provides a common way to query incremental meta-data changes for a hoodie table. + * + * This is useful in multiple places including: + * 1) HiveSync - this can be used to query partitions that changed since previous sync. + * 2) Incremental reads - InputFormats can use this API to queryxw + */ +public class TimelineUtils { + + /** + * Returns partitions that have new data strictly after commitTime. + * Does not include internal operations such as clean in the timeline. + */ + public static List<String> getPartitionsWritten(HoodieTimeline timeline) { + HoodieTimeline timelineToSync = timeline.getCommitsAndCompactionTimeline(); + return getPartitionsMutated(timelineToSync); + } + + /** + * Returns partitions that have been modified including internal operations such as clean in the passed timeline. + */ + public static List<String> getPartitionsMutated(HoodieTimeline timeline) { Review comment: I am assuming you are planning to use this API internally. Right ? ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.timeline; + +import org.apache.hudi.avro.model.HoodieCleanMetadata; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.exception.HoodieIOException; + +import java.io.IOException; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * TimelineUtils provides a common way to query incremental meta-data changes for a hoodie table. + * + * This is useful in multiple places including: + * 1) HiveSync - this can be used to query partitions that changed since previous sync. + * 2) Incremental reads - InputFormats can use this API to queryxw + */ +public class TimelineUtils { + + /** + * Returns partitions that have new data strictly after commitTime. + * Does not include internal operations such as clean in the timeline. + */ + public static List<String> getPartitionsWritten(HoodieTimeline timeline) { + HoodieTimeline timelineToSync = timeline.getCommitsAndCompactionTimeline(); + return getPartitionsMutated(timelineToSync); + } + + /** + * Returns partitions that have been modified including internal operations such as clean in the passed timeline. + */ + public static List<String> getPartitionsMutated(HoodieTimeline timeline) { Review comment: getPartitionsMutated -> getAffectedPartitions ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
