[GitHub] [hudi] Trevor-zhang commented on a change in pull request #2021: [HUDI-1218] Introduce BulkInsertSortMode as Independent class

[GitBox]

Trevor-zhang commented on a change in pull request #2021:
URL: https://github.com/apache/hudi/pull/2021#discussion_r476102080



##########
File path: 
hudi-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertInternalPartitionerFactory.java
##########
@@ -39,10 +39,4 @@ public static BulkInsertPartitioner get(BulkInsertSortMode 
sortMode) {
         throw new HoodieException("The bulk insert mode \"" + sortMode.name() 
+ "\" is not supported.");

Review comment:
       > `The bulk insert sort mode `? better?
   I think so. i have changed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org