bibhu107 opened a new pull request, #11823:
URL: https://github.com/apache/hudi/pull/11823

   
   ### Change Logs
   Two functions in `HoodieTableMetadataUtil`, 
`convertFilesToPartitionStatsRecords` and 
`convertMetadataToPartitionStatsRecords`, are being evaluated for unification. 
   These functions perform similar tasks of creating statistics for records in 
a partition. The proposal aims to combine them into a single function, 
improving code readability and maintainability.
   
   Reference: https://github.com/apache/hudi/pull/10352#discussion_r1584149612
   
   ### Impact
   This change will primarily affect the internal implementation of 
`HoodieTableMetadataUtil`. While it's not expected to impact the public API 
directly.
   
   There are simillar other functions like mentioned below : 
   - `convertFilesToColumnStatsRecords` and 
`convertMetadataToColumnStatsRecords`
   - `convertFilesToBloomFilterRecords` and 
`convertMetadataToBloomFilterRecords`
   
   Unification challenge:
   To merge these function pairs, we would need to transform 
HoodieCommitMetadata into a format compatible with the unified function. This 
transformation process could potentially introduce inefficiencies.
   
   
   ### Risk level
   Low
   
   ### Documentation Update
   N/A
   
   As this is an internal code refactoring, no user-facing documentation 
updates are required.
   
   ### Contributor's checklist
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   
   cc - @codope 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to