vinothchandar commented on a change in pull request #2008:
URL: https://github.com/apache/hudi/pull/2008#discussion_r480253789
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -87,9 +87,17 @@ public static FileInputFormat
getInputFormat(HoodieFileFormat baseFileFormat, bo
}
}
- public static String getInputFormatClassName(HoodieFileFormat
baseFileFormat, boolean realtime, Configuration conf) {
- FileInputFormat inputFormat = getInputFormat(baseFileFormat, realtime,
conf);
- return inputFormat.getClass().getName();
+ public static String getInputFormatClassName(HoodieFileFormat
baseFileFormat, boolean realtime) {
+ switch (baseFileFormat) {
+ case PARQUET:
Review comment:
this is going to fail now, probably given we have a HFile base now.
@garyli1019 can you please rebase and fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
