xushiyan commented on code in PR #119:
URL: https://github.com/apache/hudi-rs/pull/119#discussion_r1761348466
##########
crates/core/src/table/mod.rs:
##########
@@ -306,6 +330,16 @@ impl Table {
.read_file_slice_by_path_unchecked(relative_path)
.await
}
+
+ pub fn partition_filter_replace(&mut self, partition_filters:
Vec<PartitionFilter>) {
+ if self.configs.get_or_default(IsHiveStylePartitioning).to() {
+ self.partition_filters = partition_filters;
+ }
+ }
+
+ pub fn reset(&mut self) {
+ self.file_system_view.reset()
+ }
Review Comment:
@KnightChess yes understood, eventually we'll need to implement those
functionalities. But let's stick to the on-demand principle - don't "predict"
the needs, adding APIs when it becomes necessary. As of the codebase, these 2
serve for testing so let's write proper test code, and we can evolve them for
production code whenever need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
