lokeshj1703 commented on code in PR #11921:
URL: https://github.com/apache/hudi/pull/11921#discussion_r1775706138
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -914,6 +950,97 @@ private void validateAllColumnStats(
validate(metadataBasedColStats, fsBasedColStats, partitionPath, "column
stats");
}
+ private void validatePartitionStats(
+ HoodieMetadataValidationContext metadataTableBasedContext,
+ Set<String> baseDataFilesForCleaning,
+ List<String> allPartitions) throws Exception {
Review Comment:
Addressed
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -600,6 +634,8 @@ public boolean doMetadataTableValidation() {
LOG.warn("Metadata table validation failed ({}).", taskLabels);
return false;
}
+ } catch (HoodieValidationException e) {
+ throw e;
Review Comment:
This is an error where HoodieValidationException is never thrown even if
ignoreFailed is false. For example if validation exception is thrown by
partition stat validation logic, it will be caught and will lead to validation
being successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
