danny0405 commented on PR #11580: URL: https://github.com/apache/hudi/pull/11580#issuecomment-2375508787
> hey @danny0405 : I was chasing some test failures in this patch and realized that flink might have an issue. In [this](https://github.com/apache/hudi/blob/ed65de1460468ad33a374a66606c0baae6cc129b/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/CompactionUtil.java#L78) piece of code block, we generate a compaction time in the past. So, the additional validation in this patch may not sit well w/ flink. > > Do you have any thoughts on how to go about it. I kind of think only if there is no completed commits after the compaction instant, we are good to use it, there is no need to force a strong increasing sequence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
