geserdugarov opened a new pull request, #12120:
URL: https://github.com/apache/hudi/pull/12120

   ### Change Logs
   
   Fix for HUDI-5302 introduced non-deterministic behavior depending on 
combination and sequence of `,` and `:`. This MR propose support of `,` in 
composite key values, but not support of `:`. Both characters are supported for 
simple key from one field.
   
   Also, `KeyGenUtils::extractRecordKeysByFields` is used in Flink stream 
processing with buckets. Optimization of this part is critical because it's 
called from `BucketStreamWriteFunction::processElement`, which means it's 
called for each record.
   
   Before changes:
   ![09 - 
string](https://github.com/user-attachments/assets/2a14d49f-5702-401e-8e8f-14e82a65e5c0)
   
   After changes:
   ![11 - optimized 
extract](https://github.com/user-attachments/assets/5721cb15-d831-4d73-bc20-9ce9d57663e8)
   
   ### Impact
   
   Memory allocation optimized when buckets are used.
   
   ### Risk level (write none, low medium or high below)
   
   Low
   
   ### Documentation Update
   
   Explicit note about not supported `:` character in key values. Currently, 
the behavior is non-deterministic when `,` and `:` are used in key values, and 
dependent from combination and sequence.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to