linliu-code commented on code in PR #12122:
URL: https://github.com/apache/hudi/pull/12122#discussion_r1807195567


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergedReadHandle.java:
##########
@@ -166,6 +167,12 @@ private List<HoodieRecord<T>> 
doMergedRead(Option<HoodieFileReader> baseFileRead
         String key = record.getRecordKey();
         if (deltaRecordMap.containsKey(key)) {
           deltaRecordKeys.remove(key);
+          // When internal operation exists, it means there are at least one 
delete in between.
+          // Therefore, no need to merge with the base record.

Review Comment:
   The record from log record reader may not be a delete record. So its 
operation may not be `Delete` operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to