codope commented on code in PR #12177:
URL: https://github.com/apache/hudi/pull/12177#discussion_r1822173898
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala:
##########
@@ -377,6 +377,7 @@ class SparkHoodieTableFileIndex(spark: SparkSession,
val tableConfig = metaClient.getTableConfig
if (null != tableConfig.getKeyGeneratorClassName
&&
tableConfig.getKeyGeneratorClassName.equals(KeyGeneratorType.TIMESTAMP.getClassName)
+ && null !=
tableConfig.propsMap.get(TimestampKeyGeneratorConfig.TIMESTAMP_TYPE_FIELD.key())
Review Comment:
It's hard to write a functional compatibility test for this scenario.
However, I will add a unit test for the method itself and cover the scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
