yihua commented on code in PR #12178:
URL: https://github.com/apache/hudi/pull/12178#discussion_r1823208888
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java:
##########
@@ -204,6 +204,7 @@ public static HoodieTableMetaClient
init(StorageConfiguration<?> storageConf, St
if (!Objects.equals(keyGen,
"org.apache.hudi.keygen.NonpartitionedKeyGenerator")
&&
!properties.containsKey("hoodie.datasource.write.partitionpath.field")) {
builder.setPartitionFields("some_nonexistent_field");
+ builder.setShouldDropPartitionColumns(true);
Review Comment:
I think this should not be added as
`hoodie.datasource.write.drop.partition.columns` is originally intended for
compatibility with BigQuery only and it is seldomly used; there are other ways
of making BigQuery read Hudi tables. We should likely remove this write/table
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
