satishkotha commented on a change in pull request #2048: URL: https://github.com/apache/hudi/pull/2048#discussion_r488344523
########## File path: hudi-common/src/main/avro/HoodieReplaceCommitMetadata.avsc ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +{ + "namespace":"org.apache.hudi.avro.model", + "type":"record", + "name":"HoodieReplaceCommitMetadata", + "fields":[ + { + "name":"partitionToWriteStats", Review comment: Moved partitionToReplaceStats at the end. Its also possible to make this reference HoodieCommitMetadata directly i.e., HoodieReplaceCommitMetadata contains HoodieCommitMetadata and replaceFileIds. But converting between json replaceCommit and avro version will require another layer of transform code. So to keep it simple, I copied all the fields from json structure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
