danny0405 commented on code in PR #12250:
URL: https://github.com/apache/hudi/pull/12250#discussion_r1845274180
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##########
@@ -102,25 +102,46 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
return 0;
}
+ try {
+ List<HoodieInstant> instantsToArchive = getInstantsToArchive();
+ return archiveInstants(context, instantsToArchive, false);
+ } finally {
+ if (acquireLock) {
+ txnManager.endTransaction(Option.empty());
+ }
+ }
+ }
+
+ @Override
+ public int archiveInstants(HoodieEngineContext context, List<HoodieInstant>
instantsToArchive, boolean acquireLock) throws IOException {
Review Comment:
It looks like this `acquireLock` is always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
