codope commented on code in PR #12280:
URL: https://github.com/apache/hudi/pull/12280#discussion_r1850839700
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/testutils/HoodieJavaClientTestHarness.java:
##########
@@ -429,22 +428,12 @@ private void runFullValidation(HoodieWriteConfig
writeConfig,
List<String> metadataTablePartitions = FSUtils.getAllPartitionPaths(
engineContext, storage,
HoodieTableMetadata.getMetadataTableBasePath(basePath), false);
- List<MetadataPartitionType> enabledPartitionTypes =
metadataWriter.getEnabledPartitionTypes();
-
- assertEquals(enabledPartitionTypes.size(),
metadataTablePartitions.size());
Review Comment:
For secondary and functional indexes, enabledPartitionTypes do not
necessarily mean available partitions because secondary and functional index
partition type can have multiple metadata partitions. This assertion does not
add much value, hence removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
